Run iOS gen_snapshot as x86_64 arch #16323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
reviewed
Apr 6, 2018
| @@ -275,7 +275,7 @@ | |||
| ); | |||
| inputPaths = ( | |||
| "${SRCROOT}/Pods/Target Support Files/Pods-Runner/Pods-Runner-frameworks.sh", | |||
| "${PODS_ROOT}/../../../../bin/cache/artifacts/engine/ios/Flutter.framework", | |||
| "${PODS_ROOT}/../../../../bin/cache/artifacts/engine/ios-release/Flutter.framework", | |||
There was a problem hiding this comment.
Oops -- it's not! Reverted.
cbracken
force-pushed
the
ios-snapshot-with-arch
branch
from
7fbb6fe
to
cb9463f
Compare
We are about to begin building gen_snapshot as a multi-arch binary, which when run as x86_64 will generate arm64 AOT output, and when run as i386 will generate armv7 AOT output. Currently, gen_snapshot is an x86_64 binary, so this change is effectively preventative in nature, and is a no-op with the current snapshotter.
cbracken
force-pushed
the
ios-snapshot-with-arch
branch
from
cb9463f
to
4f506bd
Compare
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
We are about to begin building gen_snapshot as a multi-arch binary, which when run as x86_64 will generate arm64 AOT output, and when run as i386 will generate armv7 AOT output. Currently, gen_snapshot is an x86_64 binary, so this change is effectively preventative in nature, and is a no-op with the current snapshotter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are about to begin building gen_snapshot as a multi-arch binary,
which when run as x86_64 will generate arm64 AOT output, and when run as
i386 will generate armv7 AOT output.
Currently, gen_snapshot is an x86_64 binary, so this change is
effectively preventative in nature, and is a no-op with the current
snapshotter.