Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to limit Draggables to a single axis #17585

Closed
wants to merge 4 commits into from

Conversation

DaveShuckerow
Copy link
Contributor

Part 1 of solving #16763.

This adds a new field to the Draggable API: axis. Behavior covered in the DartDoc, but setting it limits the underlying _DragAvatar's motion to the assigned axis. When axis is null, the behavior is the same as before. As a result, this won't break anything.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@DaveShuckerow
Copy link
Contributor Author

This got reformatted automatically by my editor, I will clean it up.

@DaveShuckerow
Copy link
Contributor Author

@googlebot I have updated the authorship.

@HansMuller
Copy link
Contributor

LGTM too

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants