Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate assets under data/ to data/componentName #20534

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Duplicate assets under data/ to data/componentName #20534

merged 2 commits into from
Aug 13, 2018

Conversation

leoylung
Copy link
Contributor

No description provided.

@tvolkert
Copy link
Contributor 

Analyzing 3 directories...
   info • Use `isNotEmpty` for Iterables and Maps • packages/flutter_tools/bin/fuchsia_asset_builder.dart:93:9

@tvolkert tvolkert self-requested a review August 13, 2018 18:40
tvolkert
tvolkert approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will land on green.

@tvolkert tvolkert merged commit 5311dff into flutter:master Aug 13, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tvolkert tvolkert tvolkert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leoylung @tvolkert @googlebot