Added sample code for scaffold widget [#21136] #21613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Sep 25, 2018
| /// | ||
| /// ```dart | ||
| /// Scaffold( | ||
| /// appBar: AppBar( |
There was a problem hiding this comment.
nit: please indent by 2 rather than 4
Hixie
reviewed
Sep 25, 2018
| /// ), | ||
| /// ), | ||
| /// | ||
| /// bottomNavigationBar: BottomAppBar( |
There was a problem hiding this comment.
nit: we should be consistent about whether we want blank lines between each entry in this list or not. I'd probably go with no blank lines to be consistent with other sample code, but I can go either way if you think it's important for this example.
|
This looks fantastic, thanks! Just a few nits if you wouldn't mind updating the code a little for consistency. Let me know if you've had the opportunity to update the PR and then I can land it! |
|
@Hixie I just added the fixes you recommended to the Scaffold widget sample code. |
Fix one more formatting issue
|
LGTM! I fixed one more minor nit there on the spacing at the end. Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sample code for Scaffold widget to the repo.