textSelectionHandleColor taken from parent's context. Fixes #20219.

[ajinasokan]

textSelectionHandleColor taken from the parent widget context instead of app's overlay context. Fixes #20219.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[ajinasokan]

I signed it!

[googlebot]

CLAs look good, thanks!

[Hixie]

this won't work reliably. When you look up the Theme with Theme.of, it causes the relevant Theme to register the context so that when the Theme changes, the context is marked dirty. But that won't work here because that would mark the widget whose context was passed to TextSelectionOverlay dirty, but not the handles. So the handles wouldn't change color.

(When you use the build context of the OverlayEntry, as in the original code, then when the relevant Theme changes, it causes the overlay entry to rebuild, rebuilding the handle.)

[Hixie]

This would need a test. The most important test would be one where the color of the Theme is changed while the handles are showing; we should verify that the handles change colour. I don't believe they would, with this patch.

In general there isn't a good way to make something higher in the tree depend on a Theme elsewhere in the tree, as the PR is attempting to do here.

[goderbauer]

Closing as there hasn't been any activity for a while.