Switch to URIs for breakpoints and unskip tests on Windows #22510
Conversation
|
I think this needs #22507 in order to pass (I had a cached build of tools when I ran this). I'll rebase and try again once that's done. |
|
The failure looks like a repeat of #21741 caused by symlinks in the temp paths coming from macOS (we don't handle breakpoints sent for symlinked paths, since the VM is using the real underlying path). I've applied that fix (which only applied to one test file previously) to all integration tests to avoid this; hopefully it'll make everything green. (@goderbauer please check the new changeset and confirm if you're still happy with this). |
|
@goderbauer I pushed extra changes to handle symlinks since you approved this, let me know if you're still happy for me to land this. (I'll rebase too since it's been a while) |
addBreakpointWithScriptUri expects Uris. By coincidence, FS paths work on Mac/Linux but they fail on Windows. One of the issues in the skip comment is fixed, the other one seems not relevant here.
The default temp folders we get include symlinks which breaks breakpoints.
| @@ -11,6 +11,14 @@ import 'package:flutter_tools/src/base/process_manager.dart'; | |||
|
|
|||
| import '../src/common.dart'; | |||
|
|
|||
| /// Creates a etmporary directory but resolves any symlinks to return the real | |||
|
Ug, I didn't spot flutter-build was missing from this, so I landed it while the build was red 😕 |
addBreakpointWithScriptUri expects Uris. By coincidence, FS paths work on Mac/Linux but they fail on Windows. One of the issues in the skip comment is fixed, the other one seems not relevant here.