New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hover support for mouse pointers. #24830
Conversation
26d60d7
to
f309365
Compare
This seems mostly fine but one major issue I see is that it assumes that there's only one mouse. We should track each pointer separately, any number of them could be mice. |
Oooh, good point. OK, I've added support for multiple pointers. |
65eb268
to
fa8bdc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments from my first "let's understand what this PR does" pass. Will take another, closer look shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This implements support for hovering mouse pointers, so that mice connected to Android devices, and ChromeOS devices running Android apps will work properly. It teaches flutter_test about hover events, which required changing how they are created and used. Also modifies AnnotatedRegion to allow a region that can be located someplace other than just the origin. Along with tests for all of the above. Fixes flutter#5504
This implements support for hovering mouse pointers, so that mice connected to Android devices, and ChromeOS devices running Android apps will work properly.
It teaches flutter_test about hover events, which required changing how they are created and used.
Also modifies
AnnotatedRegion
to allow a region that can be located someplace other than just the origin.Along with tests for all of the above.
This code needs flutter/engine#6961 in order to actually receive hover events, but doesn't require it to compile.
Fixes #5504