Adds a fade in and out, rounds corners, fixes offset and fixes height of cursor on iOS #24876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoechi
added
a: text input
xster
reviewed
Nov 30, 2018
jslavitz
changed the title
|
Let me know if you're ready for another look |
|
Waiting on #24265 to land before finishing this. |
…to cursor-fixes merge
zoechi
added
the
f: material design
|
LGTM. cc @HansMuller FYI |
HansMuller
reviewed
Jan 22, 2019
xster
reviewed
Jan 25, 2019
| @@ -1283,15 +1351,30 @@ class RenderEditable extends RenderBox { | |||
| offset.applyContentDimensions(0.0, _maxScrollExtent); | |||
| } | |||
|
|
|||
| Offset _getPixelPerfectCursorOffset(Rect caretRect) { | |||
| final Offset caretPosition = localToGlobal(caretRect.topLeft); | |||
| final double pixelMultiple = 1.0 / _devicePixelRatio; | |||
There was a problem hiding this comment.
these divisions are a bit hard to read. Why not just
final Offset logicalCaretPosition = localToGlobal(caretRect.topLeft);
final int physicalCaretX = (caretPosition.dx * _devicePixelRatio).round();
final int physicalCaretY = (caretPosition.dy * _devicePixelRatio).round();
final double pixelPerfectLogicalX = globalToLocal(physicalCaretX / _devicePixelRatio); // I'm not sure what the - caretPosition.dx was for
final double pixelPerfectLogicalY = globalToLocal(physicalCaretY / _devicePixelRatio);Otherwise, aliasing around the edge seems like 'working as intended'. Just have your test not land on .499999999-.5.
There was a problem hiding this comment.
I think I'm just going to leave this logic as is? It's supposed to give the delta logical pixels to move the rect to be physically pixel perfectly aligned. So that logic isn't really going to work.
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
HansMuller
reviewed
Feb 7, 2019
| @@ -682,6 +699,22 @@ class _TextFieldState extends State<TextField> with AutomaticKeepAliveClientMixi | |||
| @override | |||
| bool get wantKeepAlive => _splashes != null && _splashes.isNotEmpty; | |||
|
|
|||
| bool get _cursorOpacityAnimates => Theme.of(context).platform == TargetPlatform.iOS ? true : false; | |||
|
|
|||
| Offset get _getCursorOffset => Offset(_iOSHorizontalCursorOffsetPixels / MediaQuery.of(context).devicePixelRatio, 0); | |||
There was a problem hiding this comment.
This appears to be used unconditionally. It should only be used if the platform is iOS.
This was referenced Feb 7, 2019
Hixie
reviewed
Feb 12, 2019
| /// | ||
| /// Defaults to a super ellipse with | ||
| // final ShapeBorder shape; | ||
|
|
There was a problem hiding this comment.
@jslavitz looks like this bit was checked in by mistake -- please take a moment to clean it. Thanks!
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
… of cursor on iOS (flutter#24876) * Fixes cursor on iOS devices
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22879.