Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let CupertinoTabScaffold handle keyboard insets too #25593

Merged
merged 2 commits into from Dec 20, 2018
Merged

Let CupertinoTabScaffold handle keyboard insets too #25593

merged 2 commits into from Dec 20, 2018

Conversation

xster
Copy link
Member

@xster xster commented Dec 20, 2018

Fixes #22923

@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Dec 20, 2018
RedBrogdon
RedBrogdon approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@RedBrogdon RedBrogdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patched my local SDK and verified that this fixes the issue with veggieseasons.

@xster
Copy link
Member Author

xster commented Dec 20, 2018

Not sure why cocoon is reporting red. The particular build isn't red on Cirrus. Merging this to build again.

@xster xster merged commit d1ec126 into flutter:master Dec 20, 2018
@xster xster deleted the tab-scaffold-inset branch December 20, 2018 23:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RedBrogdon RedBrogdon RedBrogdon approved these changes

Assignees
No one assigned
Labels
f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content in CupertinoTabView covered by keyboard
4 participants
@xster @RedBrogdon @zoechi @googlebot