Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Strut: Add StrutStyle, expose Strut API, wire up strut with dart:ui, Roll engine 31a7f4d..e7eb1c8 (7 commits) #26332

Merged
merged 39 commits into from Feb 4, 2019
Merged

Integrate Strut: Add StrutStyle, expose Strut API, wire up strut with dart:ui, Roll engine 31a7f4d..e7eb1c8 (7 commits) #26332

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
1c79865
Initial strut integration
GaryQian Jan 10, 2019
9e7785b
Modify docs, add setters/getters to renderparagraph
GaryQian Jan 10, 2019
fefa350
Merge branch 'master' of github.com:flutter/flutter into strut
GaryQian Jan 10, 2019
70546b7
API rework part 1
GaryQian Jan 11, 2019
71d2443
Cleanup and less rigid strut definition
GaryQian Jan 11, 2019
ed7abea
Support font family fallback, improve docs:
GaryQian Jan 14, 2019
2f4e7b7
Compiling and begin test work
GaryQian Jan 14, 2019
08d35e3
Merge with upstream master
GaryQian Jan 14, 2019
cc9c997
Docs work, Pass renderbox tests
GaryQian Jan 15, 2019
75d7f37
Allow default textstyle override in paragraph style
GaryQian Jan 15, 2019
f9ced02
Merge branch 'master' of github.com:flutter/flutter into strut
GaryQian Jan 16, 2019
e400c75
Add tests for strut
GaryQian Jan 16, 2019
fca3aee
More tests, remove bad imports
GaryQian Jan 16, 2019
721fa0c
Correct docs and improve descriptions.
GaryQian Jan 17, 2019
384c474
Dartdoc style comment decor
GaryQian Jan 17, 2019
6a6cfa0
Improve docs
GaryQian Jan 17, 2019
bffba21
Nits and improve Docs
GaryQian Jan 18, 2019
c96e3b8
Improve docs
GaryQian Jan 18, 2019
e8a9db7
Merge branch 'master' of github.com:flutter/flutter into strut
GaryQian Jan 18, 2019
26c3839
Add more examples
GaryQian Jan 18, 2019
de0792a
More docs changes
GaryQian Jan 18, 2019
b1c8659
Make analyzer happy
GaryQian Jan 18, 2019
fa3d676
Change lineHeight to height
GaryQian Jan 28, 2019
2991011
Pass tests
GaryQian Jan 29, 2019
3904ed8
Fix some strut nits
GaryQian Jan 29, 2019
6484256
Explain forceStrutHeight equivalency to zero TextStyle.height
GaryQian Jan 29, 2019
34ce791
Fix nits, comments
GaryQian Jan 29, 2019
85f8563
Merge branch 'master' of github.com:flutter/flutter into strut
GaryQian Jan 29, 2019
8c26ac9
Roll engine to c92df428
GaryQian Jan 30, 2019
f80eed7
Merge branch 'master' into strut
GaryQian Jan 30, 2019
d6872e7
Roll engine to e7eb1c8bf65531195fc76ba96c8fc8478ac5f554
GaryQian Jan 30, 2019
ca6a665
Merge branch 'master' into strut
GaryQian Jan 30, 2019
baab021
Add goldens
GaryQian Jan 30, 2019
c149e7f
Remove whitespace
GaryQian Jan 30, 2019
938016d
Separate tests for strut
GaryQian Jan 31, 2019
6425cd0
Kick cirrus to run checks
GaryQian Jan 31, 2019
960e1ab
Modify tests
GaryQian Jan 31, 2019
7a0da41
Additional test adjustment
GaryQian Jan 31, 2019
1b03aa2
Merge branch 'master' into strut
GaryQian Feb 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/flutter/lib/painting.dart
View file
Open in desktop
Expand Up @@ -51,6 +51,7 @@ export 'src/painting/paint_utilities.dart';
export 'src/painting/rounded_rectangle_border.dart';
export 'src/painting/shape_decoration.dart';
export 'src/painting/stadium_border.dart';
export 'src/painting/strut_style.dart';
export 'src/painting/superellipse_shape.dart';
export 'src/painting/text_painter.dart';
export 'src/painting/text_span.dart';
Expand Down