Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for getOffsetToReveal on RenderSlivers #26598

Merged
merged 1 commit into from Jan 16, 2019
Merged

Add tests for getOffsetToReveal on RenderSlivers #26598

merged 1 commit into from Jan 16, 2019

Conversation

goderbauer
Copy link
Member

Pre-work for #20893 to ensure I don't regress existing functionality while fixing the issue.

This was referenced Jan 15, 2019
Open
Closed
dnfield
dnfield approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoechi zoechi added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jan 16, 2019
@goderbauer goderbauer merged commit b4e9d0a into flutter:master Jan 16, 2019
@goderbauer goderbauer deleted the getOffsetToRevealSliverTests branch January 16, 2019 17:18
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
@goderbauer @kangwang1988
Add tests for getOffsetToReveal on RenderSlivers (flutter#26598)
6d297a1
@goderbauer goderbauer added the c: crash Stack traces logged to the console label Feb 22, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests c: crash Stack traces logged to the console framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goderbauer @dnfield @zoechi @googlebot