Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded Snippet for API Docs #28681

Merged
merged 2 commits into from Mar 1, 2019
Merged

Expanded Snippet for API Docs #28681

merged 2 commits into from Mar 1, 2019

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 28, 2019

Description

This PR adds 2 code snippets for the Expanded class in the API docs. The first a simple case, the second illustrating the use of the flex property.

Related Issues

Ref:#21136

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
    • N/A
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Mar 1, 2019
@Piinks Piinks marked this pull request as ready for review March 1, 2019 17:22
@gspencergoog
Copy link
Contributor

You might consider making these into "snippet" application samples instead, using a template. That way, people could instantiate them and try them out easily.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@Piinks Piinks merged commit 9b01d8a into flutter:master Mar 1, 2019
@Piinks Piinks deleted the expandedSample branch March 1, 2019 23:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants