Add sample code to Icons Class #31725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihaohong
added
d: api docs
shihaohong
suggested changes
Apr 28, 2019
| @@ -34,10 +55,12 @@ class Icons { | |||
| // BEGIN GENERATED | |||
|
|
|||
| /// <i class="material-icons md-36">360</i> — material icon named "360". | |||
| static const IconData threesixty = IconData(0xe577, fontFamily: 'MaterialIcons'); | |||
| static const IconData threesixty = | |||
There was a problem hiding this comment.
You should revert all of these changes back to one-liners, since they're not related to your current PR
| @@ -21,6 +21,27 @@ import 'package:flutter/widgets.dart'; | |||
| /// uses-material-design: true | |||
| /// ``` | |||
| /// | |||
| /// {@tool snippet --template=stateless_widget_scaffold} | |||
| /// | |||
| /// This example shows how to use [Icons] to create three icons: fast rewind, | |||
There was a problem hiding this comment.
This example creates three [Icons], fast_rewind, play_arrow and fast_forward, in that order.
| @@ -21,6 +21,27 @@ import 'package:flutter/widgets.dart'; | |||
| /// uses-material-design: true | |||
| /// ``` | |||
| /// | |||
| /// {@tool snippet --template=stateless_widget_scaffold} | |||
There was a problem hiding this comment.
[Nice-to-have] Adding a sample output image like ListTile docs. See https://github.com/flutter/assets-for-api-docs for example pull requests.
Let me know if you have any questions about how to get this set up!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add sample code to Material Icons class
Related Issues
Related to #21136
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?