New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ScrollbarPainter thumbExtent calculation and add padding #31763
Merged
LongCatIsLooong
merged 41 commits into
flutter:master
from
LongCatIsLooong:scrollable-obstructions
May 29, 2019
Merged
Changes from 40 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
c46cec9
WIP
LongCatIsLooong 42bf521
page calculation
LongCatIsLooong ef0a54e
WIP
LongCatIsLooong a2cec76
WIP
LongCatIsLooong 4432ff3
scrollbar x position
LongCatIsLooong 134df49
fix tests
LongCatIsLooong 7792e4d
WIP
LongCatIsLooong 0386126
add tests
LongCatIsLooong 71edbc8
Merge remote-tracking branch 'upstream/master' into scrollable-obstru…
LongCatIsLooong 4e4c640
Merge remote-tracking branch 'upstream/master' into scrollable-obstru…
LongCatIsLooong c06299f
fix tests
LongCatIsLooong 4433a94
more tests
LongCatIsLooong ffddf9c
remove newline
LongCatIsLooong 5833e34
typo
LongCatIsLooong 96924ec
comments
LongCatIsLooong 74c79a8
replace new syntax
LongCatIsLooong 6a62e9c
Merge branch 'scrollable-obstructions' of github.com:LongCatIsLooong/…
LongCatIsLooong 2532fdb
Merge branch 'master' into scrollable-obstructions
LongCatIsLooong 5e1e04a
Review
LongCatIsLooong f267818
review
LongCatIsLooong 1d94387
Use ready-made wheels
LongCatIsLooong 5aaf9d1
WIP, updating according to iOS behavior
LongCatIsLooong 0ab4191
WIP
LongCatIsLooong 7eaacda
Update thumbExtent calculation
LongCatIsLooong 8e31413
fix extentInside
LongCatIsLooong 12885d2
Could this be working?
LongCatIsLooong a78021f
fix docs
LongCatIsLooong 6ded32b
english
LongCatIsLooong 4d3e39e
review, WIP
LongCatIsLooong 2357997
add new test for material
LongCatIsLooong 4271b67
Update scrollbar.dart
LongCatIsLooong 387c5cd
update comments and tests
LongCatIsLooong 5578ad2
Merge branch 'scrollable-obstructions' of github.com:LongCatIsLooong/…
LongCatIsLooong 128c12b
indentation
LongCatIsLooong 535d25c
change wording
LongCatIsLooong be616d3
review
LongCatIsLooong d6c9632
remove whitespace
LongCatIsLooong 67d9e58
trailing comma
LongCatIsLooong 2bea4cf
pixel -> logical pixel
LongCatIsLooong 54d37d1
must -> should
LongCatIsLooong ff2fff9
Merge branch 'master' into scrollable-obstructions
LongCatIsLooong File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FixedScrollMetrics should assert that these constraints are true.