Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that offsets are returned in logical pixels #33620

Merged
merged 2 commits into from May 31, 2019
Merged

Document that offsets are returned in logical pixels #33620

merged 2 commits into from May 31, 2019

Conversation

goderbauer
Copy link
Member

Description

Make documentation more specific to avoid user confusion.

Related Issues

None

Tests

I added the following tests:

None, doc only change.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels. labels May 30, 2019
Piinks
Piinks approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making this clearer. :)

@goderbauer
Copy link
Member Author

/cc @adazh

tvolkert
tvolkert approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer merged commit 3c24c5b into flutter:master May 31, 2019
@goderbauer goderbauer deleted the driverDocs branch May 31, 2019 15:55
kiku-jw pushed a commit to kiku-jw/flutter that referenced this pull request Jun 14, 2019
@goderbauer @kiku-jw
Document that offsets are returned in logical pixels (flutter#33620)
559bf05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvolkert tvolkert tvolkert approved these changes

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goderbauer @tvolkert @Piinks @googlebot