Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ios_add2app Pods directory and add to gitignore #33772

Merged
merged 1 commit into from Jun 3, 2019

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 3, 2019

Description

Don't track Pods directory in the ios_add2app integration test.

Related Issues

Fixes #33766.

Tests

I ran ios_add2app integration test ./build_and_test.sh, all tests passed.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jmagman jmagman requested a review from dnfield June 3, 2019 17:30
@dnfield
Copy link
Contributor

dnfield commented Jun 3, 2019

How much time does this add to the test, and can we do anything to make sure it doesn't lead to flakiness?

I included these to try to make the test more hermetic :\

@jmagman
Copy link
Member Author

jmagman commented Jun 3, 2019

How much time does this add to the test, and can we do anything to make sure it doesn't lead to flakiness?

I was following in the footsteps of #9464 and #9550. How would it cause flakiness?

The top-level https://github.com/flutter/flutter/blob/master/.gitignore includes **/ios/**/Pods/ so I think the intention was to never check in a Pods directory for any checked in Xcode project, but this integration test doesn't match that pattern.

@dnfield
Copy link
Contributor

dnfield commented Jun 3, 2019

Hm. Looking at the test execution, looks like I was wrong about how much time it would add.

The flakiness concern is that we're now downloading and generating more content - but as long as it's not making this test more flaky that's fine with me. We can watch it.

LGTM

@jmagman jmagman merged commit 9474a9f into flutter:master Jun 3, 2019
@jmagman jmagman deleted the pods branch June 3, 2019 21:29
kiku-jw pushed a commit to kiku-jw/flutter that referenced this pull request Jun 14, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants