Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add equals and hashCode to Tween" #37895

Merged
merged 1 commit into from Aug 9, 2019
Merged

Revert "Add equals and hashCode to Tween" #37895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 1 addition & 16 deletions packages/flutter/lib/src/animation/tween.dart
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'dart:ui' show Color, Rect, Size, hashValues;
import 'dart:ui' show Color, Size, Rect;

import 'package:flutter/foundation.dart';

Expand Down Expand Up @@ -260,21 +260,6 @@ class Tween<T extends dynamic> extends Animatable<T> {
return lerp(t);
}

@override
int get hashCode {
return hashValues(begin, end);
}

@override
bool operator ==(dynamic other) {
if (identical(this, other))
return true;
if (other.runtimeType != runtimeType)
return false;
final Tween<T> typedOther = other;
return typedOther.begin == begin && typedOther.end == end;
}

@override
String toString() => '$runtimeType($begin \u2192 $end)';
}
Expand Down
14 changes: 0 additions & 14 deletions packages/flutter/test/animation/tween_test.dart
View file
Open in desktop
Expand Up @@ -93,18 +93,4 @@ void main() {
expect(tween.lerp(0.5), 100.0);
expect(tween.lerp(1.0), 100.0);
});

test('Tween equals', () {
final Tween<double> doubleTween1 = Tween<double>(begin: 10, end: 22);
final Tween<double> doubleTween2 = Tween<double>(begin: 10, end: 22);
final Tween<double> doubleTween3 = Tween<double>(begin: 33, end: 44);
final Tween<int> intTween = Tween<int>(begin: 33, end: 44);
final Tween<double> constantTween = ConstantTween<double>(10);

expect(doubleTween1 == doubleTween1, isTrue);
expect(doubleTween1 == doubleTween2, isTrue);
expect(doubleTween2 == doubleTween3, isFalse);
expect(doubleTween2 == intTween, isFalse);
expect(doubleTween1 == constantTween, isFalse);
});
}