Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inspector details subtree depth configurable. #39085

Merged
merged 4 commits into from Aug 28, 2019
Merged

Make inspector details subtree depth configurable. #39085

merged 4 commits into from Aug 28, 2019

Conversation

kenzieschmoll
Copy link
Member

Subtree depth can now be specified in the request for getDetailsSubtree .

  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 22, 2019
@kenzieschmoll kenzieschmoll mentioned this pull request Aug 28, 2019
Closed
jacob314
jacob314 reviewed Aug 28, 2019
View reviewed changes
packages/flutter/test/widgets/widget_inspector_test.dart
@@ -253,14 +253,14 @@ class TestWidgetInspectorService extends Object with WidgetInspectorService {
}

Future<Object> testExtension(String name, Map<String, String> arguments) async {
expect(extensions.containsKey(name), isTrue);
expect(extensions, contains(name));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

jacob314
jacob314 approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kenzieschmoll
Copy link
Member Author

FYI @goderbauer

goderbauer
goderbauer approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenzieschmoll kenzieschmoll merged commit 13f18d5 into flutter:master Aug 28, 2019
@kenzieschmoll kenzieschmoll deleted the inspectorSubtreeDepth branch August 28, 2019 21:02
This was referenced Aug 29, 2019
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacob314 jacob314 jacob314 approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kenzieschmoll @jacob314 @goderbauer @googlebot @fluttergithubbot