Allow independent theming of Persistent and Modal bottom sheets Background Color #39333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: material design
clocksmith
approved these changes
Aug 28, 2019
rami-a
approved these changes
Aug 29, 2019
HansMuller
reviewed
Aug 30, 2019
| /// Value for [BottomSheet.backgroundColor] when the Bottom sheet is presented | ||
| /// as a modal bottom sheet. | ||
| /// | ||
| /// If null, [BottomSheet.backgroundColor] defaults to [backgroundColor]. |
There was a problem hiding this comment.
The defaulting rules for modal bottom sheets shouldn't be documented here. And line 464 in bottom_sheet.dart doesn't default to the theme's backgroundColor when modalBackgroundColor is null.
HansMuller
reviewed
Aug 30, 2019
| @@ -141,12 +141,16 @@ void main() { | |||
| expect(material.clipBehavior, clipBehavior); | |||
| }); | |||
|
|
|||
| testWidgets('BottomSheetThemeData.modalElevation takes priority over BottomSheetThemeData.elevation for modal bottom sheets', (WidgetTester tester) async { | |||
| testWidgets('Modal bottom sheet-specific parameters take priority over general bottom sheet parameters for modal bottom sheets', (WidgetTester tester) async { | |||
There was a problem hiding this comment.
If the title is accurate then we should be verifying that a modal bottom sheet's background and elevation are defined by the bottom sheet theme's background and elevation properties when modalElevation and modalBackgroundColor are null.
| @@ -461,7 +461,7 @@ Future<T> showModalBottomSheet<T>({ | |||
| theme: Theme.of(context, shadowThemeOnly: true), | |||
| isScrollControlled: isScrollControlled, | |||
| barrierLabel: MaterialLocalizations.of(context).modalBarrierDismissLabel, | |||
| backgroundColor: backgroundColor, | |||
| backgroundColor: backgroundColor ?? Theme.of(context).bottomSheetTheme.modalBackgroundColor, | |||
There was a problem hiding this comment.
Shouldn't this be:
backgroundColor ?? Theme.of(context).bottomSheetTheme.modalBackgroundColor ?? Theme.of(context).bottomSheetTheme.backgroundColor;
It would be best to allow Theme.of(context).bottomSheetTheme to be null and to cache the value, so:
final BottomSheetThemeData theme = Theme.of(context).bottomSheetTheme;
backgroundColor: backgroundColor ?? theme?.modalBackgroundColor ?? theme?.backgroundColor;
HansMuller
reviewed
Sep 3, 2019
HansMuller
approved these changes
Sep 4, 2019
| @@ -427,6 +427,10 @@ class _ModalBottomSheetRoute<T> extends PopupRoute<T> { | |||
| /// that a modal [BottomSheet] needs to be displayed above all other content | |||
| /// but the caller is inside another [Navigator]. | |||
| /// | |||
| /// The optional [backgroundColor], [elevation], [shape], and [clipBehavior] | |||
| /// parameters can be passed in to customize the appearance and behavior of | |||
| /// persistent bottom sheets. | |||
There was a problem hiding this comment.
I think you're referring to modal bottom sheets here
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BottomSheetThemeData has an additional field modalBackgroundColor which makes it possible to set different background colors between persistent and modal bottom sheets.
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?