[Gallery] Add Material Study app Rally as an example app #41090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perclasson
requested review from
clocksmith,
willlarche,
rami-a and
johnsonmh
fluttergithubbot
added
d: examples
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
clocksmith
reviewed
Sep 23, 2019
| _tabController.addListener(() { | ||
| if (_tabController.indexIsChanging && | ||
| _tabController.previousIndex != _tabController.index) { | ||
| setState(() {}); |
There was a problem hiding this comment.
What is the nit here, I don't follow?
There was a problem hiding this comment.
usually empty functions in flutter/flutter are written as () { } instead of () {}
perclasson
force-pushed
the
add_rally_to_examples
branch
from
626f005
to
b17edae
Compare
clocksmith
approved these changes
Sep 25, 2019
perclasson
force-pushed
the
add_rally_to_examples
branch
2 times, most recently
from
cb82127
to
5f610e3
Compare
perclasson
force-pushed
the
add_rally_to_examples
branch
from
5f610e3
to
af914e0
Compare
|
Reopening the pull request. |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Flutter sample app based on the Material study Rally (a hypothetical, personal finance app). It showcases custom tabs, custom painted widgets, and custom animations.
Related Issues
N/A
Tests
I added the following tests:
N/A
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?