Fix issue with forward-delete in editable text widget #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,7 +52,7 @@ class EditableString implements KeyboardClient { | |||
| } | |||
|
|
|||
| String textAfter(TextRange range) { | |||
| return text.substring(range.end); | |||
| return text.substring(range.end, text.length); | |||
There was a problem hiding this comment.
won't that be guaranteed to go past the end?
I thought that's what omitting the argument meant, in fact.
There was a problem hiding this comment.
Hm, let me re-examine that change.
There was a problem hiding this comment.
End is exclusive, but you're right this is the default behavior. So the change is harmless but irrelevant.
|
LGTM without the textAfter change. |
krisgiesing
added a commit
that referenced
this pull request
Nov 17, 2015
Fix issue with forward-delete in editable text widget
This was referenced Jan 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes index issues when a forward delete is attempted at the end of the text range. Logic now mirrors similar checks done at the beginning of the text range.