New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
l10n tool improvements, stocks app refresh #44313
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dev/tools/localization/gen_l10n.dart
Outdated
/// | ||
/// ``` | ||
/// dependencies: | ||
/// # rest of dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including "rest of dependencies" twice doesn't look right. Maybe just include the second one.
/// dependencies: | ||
/// # rest of dependencies | ||
/// | ||
/// flutter_localizations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since developers will likely cut-and-paste this, maybe include a comment. For example:
/// # Internationalization support.
/// flutter_localizations:
/// sdk: flutter
...
Actually, when there's a gen_l10n doc to point at, the comment should include a link.
Description
Adds a help flag, as well as help messages to the
gen_l10n.dart
tool. This also refreshes the stocks app to reflect the new changes to the tool, while fixing a typo in theregenerate.md
tutorial.Issues
Related to #41437