Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gold to fallback on skipping comparator when offline #44619

Merged
merged 3 commits into from Nov 15, 2019
Merged

Update Gold to fallback on skipping comparator when offline #44619

merged 3 commits into from Nov 15, 2019

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Nov 11, 2019 •
edited

Description

This PR adds the functionality to flutter_goldens that allows for the tests to skip when there is no network connection. Without it, testing will fail when offline.

Related Issues

Fixes #44456

Tests

FlutterLocalGoldenFileComaparator.fromDefaultComparator returns the FlutterSkippingGoldenFileComparator when offline.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. team: flakes a: quality A truly polished experience a: annoyance Repeatedly frustrating issues with non-experimental functionality labels Nov 11, 2019
goderbauer
goderbauer approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks merged commit b1ca7f4 into flutter:master Nov 15, 2019
@Piinks Piinks deleted the goldNetwork branch November 22, 2019 00:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@darielopper darielopper darielopper approved these changes

Assignees
No one assigned
Labels
a: annoyance Repeatedly frustrating issues with non-experimental functionality a: quality A truly polished experience a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Golden file testing for flutter/flutter fails ugly when there is no network connection
4 participants
@Piinks @goderbauer @darielopper @googlebot