Migrate TextTheme to 2018 APIs. #45745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: material design
|
FWIW the Material team gave their ok for naming things One thing we'd have to add to this PR is a comment in the doc somewhere acknowledging that the numbering scheme changed so |
This was referenced Jan 3, 2020
|
I'm closing this because the work has moved to another PR: #48547 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't complete, we also have to migrate the 586 usages of these APIs to the new terms, and write tests that verify the old and new terms work together peacefully.
We also should check with the material team about the use of
bodyText1vsbody1.