Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run" #47264

Merged
merged 1 commit into from Dec 18, 2019
Merged

Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run" #47264

merged 1 commit into from Dec 18, 2019

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Dec 18, 2019

Reverts #46928

Caused failures in
complex_layout_ios__compile
flutter_gallery_ios__compile
hello_world_ios__compile

stderr: tar: /Users/flutter/.cocoon/flutter/dev/benchmarks/complex_layout/build/ios/Release-iphoneos/sample_flutter_app.app: Cannot stat: No such file or directory stderr: tar: Error exit delayed from previous errors. 2

@jmagman
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of t…
994bbb6 
…he built app during flutter run (#46928)"

This reverts commit e54e301.
@fluttergithubbot fluttergithubbot added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 18, 2019
@jmagman
Copy link
Member Author

jmagman commented Dec 18, 2019

Straight revert, merging to green out the build.

@jmagman jmagman merged commit 65ad8d8 into master Dec 18, 2019
@dnfield dnfield deleted the revert-46928-rename-proj branch December 19, 2019 00:32
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
platform-ios iOS applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmagman @googlebot @fluttergithubbot