Make build_aar_*_tests actually use release builds. #48893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
team
mkustermann
approved these changes
Jan 16, 2020
blasten
approved these changes
Jan 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test claims intends to be creating release builds, but actually it is creating profile builds.
I've updated the test to use release builds. This is important because we run this test on the 3xH configuration, which only compiles release builds.
See https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8891214368988307984/+/steps/flutter_test_hostonly_devicelab_tests/0/stdout for a resulting error.