Generate bitcode for plugin frameworks for flutter build ios-framework #49102
+111
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
tool
jmagman
added this to Awaiting triage
in Tools - existing app integration review
via automation
fluttergithubbot
added
the
team
jmagman
commented
Jan 18, 2020
Comment on lines
-269
to
-272
| Directory outputDirectory, | ||
| BuildMode mode, | ||
| Directory iPhoneBuildOutput, | ||
| Directory simulatorBuildOutput, |
There was a problem hiding this comment.
These params were unused.
jmagman
moved this from Awaiting triage
to Engineer reviewed
in Add-to-app - iOS tool review
jmagman
moved this from Awaiting triage
to Engineer reviewed
in Tools - existing app integration review
| final String emptyBitcodeMarker = lines | ||
| .skip(index - 1) | ||
| .take(3) | ||
| .firstWhere( |
There was a problem hiding this comment.
Thanks I had "fun" writing it.
jmagman
commented
Jan 21, 2020
There was a problem hiding this comment.
Are we testing the flow of:
flutter build ios --debug flutter build ios-framework # verify bitcode?
You mean to prove the Release plugins are linking against the Release version of Flutter.framework? No, but that's a good idea (though will add a good chunk of time to this test).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The plugin frameworks didn't have bitcode embedded because they were being built, not archived. Add
BITCODE_GENERATION_MODEwhen building to force marker or actual bitcode, depending on configuration.While building the Flutter plugins, they were linking on the last version of Flutter.framework copied from
flutter build/run. So if you ranflutter build ios --debugthenflutter build ios-framework, the Release plugins would not compile with bitcode since they were linking on the debug version of Flutter.framework, which does not contain bitcode.Related Issues
Fixes #48092
Tests
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change