Reland elide long tree walks #49891
Merged
Reland elide long tree walks #49891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit effc019.
fluttergithubbot
added
the
framework
|
It seems to still be failing the test for a different reason (doesn't seem to be eliding the tree walk?) |
|
This seems to be failing now on |
|
Both flakes - rerunning, and filed #49917 The other flake was a timeout during setup. Not sure if we have a bug tracking that, it's been happening more recently. |
|
Could Cirrus be providing the wrong service account? IT looks like it is trying to authenticate with an account I haven't seen before. |
|
CI all green now |
This was referenced Feb 4, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #48413
Removes bad assertion from test (it isn't relevant to the test, forgot to remove it.