Add Message.isPlural, Message.getCountPlaceholder() to gen_l10n_types #50132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
team
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
HansMuller
added
the
a: internationalization
shihaohong
approved these changes
Feb 4, 2020
| @@ -673,7 +681,7 @@ class LocalizationsGenerator { | |||
| } | |||
|
|
|||
| final Message message = Message(bundle, key); | |||
| if (pluralValueRE.hasMatch(message.value)) | |||
| if (message.isPlural) | |||
There was a problem hiding this comment.
I think we can remove line 357 static RegExp _pluralRE..., since it's not being used anywhere else
There was a problem hiding this comment.
Oops, thanks for catching that!
HansMuller
force-pushed
the
gen_l10n_add_is_plural
branch
from
38f317d
to
8e4e0c6
Compare
HansMuller
force-pushed
the
gen_l10n_add_is_plural
branch
from
8e4e0c6
to
2b965d3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the code for detecting plural messages into the Message class.
The existing tests cover the change.