Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change capability for test tiles_scroll_perf_iphonexs__timeline_summary #50385

Merged
merged 1 commit into from Feb 8, 2020
Merged

change capability for test tiles_scroll_perf_iphonexs__timeline_summary #50385

merged 1 commit into from Feb 8, 2020

Conversation

keyonghan
Copy link
Contributor

We are changing the capability of tiles_scroll_perf_iphonexs__timeline_summary to mac/ios for now.

The context is that we have disabled mac/iphonexs devicelab host, and there is no iphone X device available.

@fluttergithubbot fluttergithubbot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Feb 8, 2020
dnfield
dnfield reviewed Feb 8, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmagman
jmagman approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmagman jmagman merged commit 0ffecc6 into flutter:master Feb 8, 2020
@keyonghan
Copy link
Contributor Author

Thanks for the merge @jmagman

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
@keyonghan keyonghan deleted the update_test branch April 25, 2022 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnfield dnfield dnfield left review comments

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@keyonghan @jmagman @dnfield @googlebot @fluttergithubbot