Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of Can't find \android\app${assetsDirectory} #50913 #51158

Merged
merged 1 commit into from Feb 23, 2020

Conversation

shihchanghsiungsonos
Copy link
Contributor

Description

This PR fixes the issue caused by #50047

Related Issues

Fix this issue:
#50913

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 21, 2020
@jmagman jmagman added this to Awaiting triage in Add-to-app - Android tool review via automation Feb 21, 2020
@jmagman jmagman added this to Awaiting triage in Tools - existing app integration review via automation Feb 21, 2020
@blasten blasten merged commit 3f9d08a into flutter:master Feb 23, 2020
Add-to-app - Android tool review automation moved this from Awaiting triage to Engineer reviewed Feb 23, 2020
Tools - existing app integration review automation moved this from Awaiting triage to Engineer reviewed Feb 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
Add-to-app - Android tool review
  
Engineer reviewed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants