Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-land "Retry cURL downloads" #51518

Merged
merged 2 commits into from Feb 27, 2020

Conversation

christopherfujino
Copy link
Member

Description

This is a re-land of #50731, which was reverted because dart infra's version of curl didn't support --retry-connrefused. This re-lands the retry flags and leaves off the --retry-connrefused flag.

Related Issues

#50730

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@jmagman
Copy link
Member

jmagman commented Feb 27, 2020

Did we ever get an answer to #50731 (comment) from @zanderso?

Any reason not to keep the default exponential backoff behavior?

@christopherfujino
Copy link
Member Author

christopherfujino commented Feb 27, 2020

Did we ever get an answer to #50731 (comment) from @zanderso?

Any reason not to keep the default exponential backoff behavior?

Nope. @fkorotkov, should we not use the default behavior?

@fkorotkov
Copy link
Contributor

@christopherfujino 🤷‍♂ yeah, let's keep it simple then with just retry count.

@christopherfujino
Copy link
Member Author

@jmagman removed explicit 5 second delay, PTAL

@christopherfujino christopherfujino merged commit 2cb0aa0 into flutter:master Feb 27, 2020
@christopherfujino christopherfujino deleted the reland-curl-retry branch February 27, 2020 19:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants