Fix simctl process exceptions not being caught #51916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
tool
christopherfujino
changed the title
zanderso
reviewed
Mar 6, 2020
| try { | ||
| result = processUtils.run( | ||
| result = await _processUtils.run( |
There was a problem hiding this comment.
The issue indicates that the user might be able to avoid the ProcessExceptions by fixing a plist file. Should the throwToolExit include that in the message?
| @@ -187,7 +212,7 @@ class SimControl { | |||
|
|
|||
| Future<void> takeScreenshot(String deviceId, String outputPath) async { | |||
| try { | |||
| await processUtils.run( | |||
| await _processUtils.run( | |||
| <String>[_xcrunPath, 'simctl', 'io', deviceId, 'screenshot', outputPath], | |||
| throwOnError: true, | |||
| ); | |||
There was a problem hiding this comment.
I'm not sure failing to take a screenshot should throw a tool exit. Maybe it should just print an error and continue?
zanderso
approved these changes
Mar 6, 2020
christopherfujino
added
waiting for customer response
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
simctlprocess exceptions not being caught because an async call in a try/catch wasn't being awaited.Also added direct injection to
IOSSimulatorUtils,SimControlandIOSSimulatorclasses.Related Issues
Fixes #39759.
Tests
Added tests to verify
SimControlmethods properly caught process exceptions and emitted tool exits. Also refactored many tests to directly inject dependencies toIOSSimulatorUtilsandSimControlclasses.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].