Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo of showCupertinoModalPopup documentation comment #52995

Merged
merged 1 commit into from Apr 16, 2020

Conversation

mono0926
Copy link
Contributor

Description

Fix typo of showCupertinoModalPopup documentation comment.

Related Issues

None.

Tests

None.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Mar 21, 2020
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@mono0926
Copy link
Contributor Author

mono0926 commented Mar 21, 2020

@Hixie

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

This is just a fix of typo, so there are no tests.

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite web_tests-3-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_tests-5-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@LongCatIsLooong
Copy link
Contributor

Hi @mono0926 some tests keep failing. Could you rebase this pull request to the tip of the tree and see if that fixes the tests?

@mono0926
Copy link
Contributor Author

@LongCatIsLooong

Could you rebase this pull request to the tip of the tree and see if that fixes the tests?

I did it, but there are failed tests, which seems to be not related this change 🤔

@fluttergithubbot fluttergithubbot merged commit 16cc2f3 into flutter:master Apr 16, 2020
@mono0926 mono0926 deleted the patch-1 branch April 17, 2020 03:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants