Increase xcdevice timeout to 2 seconds

[jmagman]

Description

xcdevice was returning before it found all tethered devices on some machines, flakily. Up the timeout to 2 seconds. :-(

Related Issues

Fixes #53182

Tests

Updated xcode_tests with new behavior.

Checklist

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• I signed the [CLA].
• I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
• I read the [Tree Hygiene] wiki page, which explains my responsibilities.
• I updated/added relevant documentation (doc comments with ///).
• All existing and new tests are passing.
• The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

• No, no existing tests failed, so this is not a breaking change.
• Yes, this is a breaking change. If not, delete the remainder of this section.

[christopherfujino]

I remember there was discussion around this, but what is the default again? @jmagman

[jmagman]

I remember there was discussion around this, but what is the default again? @jmagman

I don't think the default is documented, but without a timeout it returns as soon as it discovers all the tethered devices and simulators, I believe. So on my machine it's <0.5 seconds. For some reason on some machines it takes longer than a second (at least I'm guessing that's what's happening) so this PR is to let xcdevice take the time it needs. This is kind of speculation though since the help text doesn't say.

xcdevice list [--timeout=sec]
	Lists all available devices and simulators. A higher timeout value may be required to detect network devices and paired Apple Watches.

[christopherfujino]

I'm getting ~6 seconds running time xcrun xcdevices list locally with nothing plugged in.

[christopherfujino]

Analysis is failing with:

warning • The parameter 'timeout' is required • packages/flutter_tools/lib/src/macos/xcode.dart:512:53 • missing_required_param

[jmagman]

I'm getting ~6 seconds running time xcrun xcdevices list locally with nothing plugged in.

Hmm, maybe I need to up it to 2 seconds then. I've seen missing plugged in devices quite a few times in the devicelab today.

[christopherfujino]

LGTM

[jmagman]

This makes me sad.