Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable deploy_gallery after renewing the distribution certs #54159

Merged
merged 1 commit into from Apr 7, 2020
Merged

Re-enable deploy_gallery after renewing the distribution certs #54159

merged 1 commit into from Apr 7, 2020

Conversation

digiter
Copy link
Contributor

@digiter digiter commented Apr 7, 2020

#54024 Description

The distribution certs was expired which caused the test to fail. We have renewed the certs and this PR will re-enable the test.

Related Issues

Fixes #54016

Tests

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot fluttergithubbot merged commit 45c51e1 into flutter:master Apr 7, 2020
digiter added a commit that referenced this pull request Apr 7, 2020
digiter added a commit that referenced this pull request Apr 7, 2020
@digiter digiter deleted the re-enable-deploy branch April 7, 2020 18:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[certificate] Renew publishing certificate to deploy the flutter gallery app
4 participants