Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bindings dependency workaround #54286

Merged

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Apr 8, 2020

DO NOT SUBMIT until customers are migrated!! Customers are migrated.

Description

This reverts commit 0089896 of #54212, which was only submitted to allow migrating our customers without breaking them.

Related Issues

Pre-work for #6827.

Tests

I added the following tests:

  • adjusted tests to make them no longer dependent on the workaround.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

This reverts commit 0089896.
@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 8, 2020
@goderbauer goderbauer changed the title Revert bindings dependency workaround [WIP] Revert bindings dependency workaround Apr 8, 2020
@goderbauer
Copy link
Member Author

(marked WIP so it is not accidentally submitted before migration is done)

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once internal customers ready

@goderbauer goderbauer changed the title [WIP] Revert bindings dependency workaround Revert bindings dependency workaround Apr 10, 2020
@goderbauer
Copy link
Member Author

Internal customers have been migrated (cl/305890946). This will submit when the tree turns green.

@fluttergithubbot fluttergithubbot merged commit 6c04830 into flutter:master Apr 10, 2020
@goderbauer goderbauer deleted the removeworkaorundlifecycle branch November 11, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants