WIP: Update DialogTheme to match the other theme patterns #54642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the effort to update the Themes in the Material library easier to use and understand, this PR updates the
DialogTheme
class to match the updated design.The
DialogTheme
was unfortunately one of the early Themes and doesn't follow the current design. TheDialogTheme
class isn't a widget and is actually just the data class that a theme would normally use. To fix this we have:DialogTheme
toDialogThemeData
.These are breaking changes so existing apps using
DialogTheme
will need to be updated (migration guide coming soon).Tests
The current tests in the material library have been updated to accommodate these changes as well as fully test the new functionality.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them?