Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update DialogTheme to match the other theme patterns #54642

Closed
wants to merge 1 commit into from

Conversation

darrenaustin
Copy link
Contributor

Description

As part of the effort to update the Themes in the Material library easier to use and understand, this PR updates the DialogTheme class to match the updated design.

The DialogTheme was unfortunately one of the early Themes and doesn't follow the current design. The DialogTheme class isn't a widget and is actually just the data class that a theme would normally use. To fix this we have:

  • Renamed DialogTheme to DialogThemeData.
  • Provided a new DialogTheme class that is an inherited widget that can be used to override the dialog properties for a widget subtree.
  • Changed the default shape's border radius from 2.0 to 4.0 to match the current Material specification.

These are breaking changes so existing apps using DialogTheme will need to be updated (migration guide coming soon).

Tests

The current tests in the material library have been updated to accommodate these changes as well as fully test the new functionality.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them?

  • Yes, this is a breaking change.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

- DialogTheme renamed to DialogThemeData
- New DialogTheme class that is an inherited widget
- Changed the default shape's border radius from 2.0 to 4.0
@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 13, 2020
@darrenaustin darrenaustin marked this pull request as draft April 13, 2020 08:54
@darrenaustin darrenaustin deleted the dialog_theme branch July 23, 2020 02:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants