Pass in runtime to ios_app_with_watch_companion simctl create #54899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
team
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
10 tasks
| for (final String runtime in LineSplitter.split(availableRuntimes)) { | ||
| // These seem to be in order, so allow matching multiple lines so it grabs | ||
| // the last (hopefully latest) one. | ||
| final RegExpMatch iOSRuntimeMatch = iOSRuntimePattern.firstMatch(runtime); |
There was a problem hiding this comment.
I thought we wanted to grab the last one?
There was a problem hiding this comment.
never mind, i forgot how loops work.
christopherfujino
approved these changes
Apr 15, 2020
| } | ||
| } | ||
| if (iOSSimRuntime == null) { | ||
| return TaskResult.failure('No iOS Simulator runtime found, available runtimes:\n$availableRuntimes'); |
There was a problem hiding this comment.
nit: can we wait to return until after we've also checked for the watchOS runtime, to optimize for the situation where the user has to install both?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The versions of
simctlinstalled on the devicelab machines require a runtime argument.Parse the output of
simctl list runtimesand pass intosimctl createwhen creating iOS and watchOS simulators.Related Issues
#54892
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change