Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus traversal regions to account for transforms. #55600

Merged
merged 1 commit into from Apr 27, 2020
Merged

Fix focus traversal regions to account for transforms. #55600

merged 1 commit into from Apr 27, 2020

Conversation

gspencergoog
Copy link
Contributor

Description

This fixes the rect and size accessors for FocusNode to properly transform the widget rect into global coordinates for processing by the focus traversal algorithm.

Related Issues

Tests

  • Added a test that verifies that the rectangle, size, and offset are properly computed.

Breaking Change

  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 24, 2020
@gspencergoog gspencergoog requested review from goderbauer and darrenaustin and removed request for goderbauer April 24, 2020 20:23
darrenaustin
darrenaustin approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check the math that closely in the tests, but LGTM.

@fluttergithubbot fluttergithubbot merged commit 7ab8767 into flutter:master Apr 27, 2020
@gspencergoog gspencergoog deleted the focus_transforms branch November 2, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenaustin darrenaustin darrenaustin approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Focus navigation doesn't take transform into account when computing bounds
4 participants
@gspencergoog @darrenaustin @googlebot @fluttergithubbot