Fix behavior change due to incorrect initial floating setting #55651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
customer:money observed a regression in InputDecoration due to 6852605. Looking through code, I realized that the
isInitiallyFloating
parameter is not correctly obeying the newly introducedFloatingLabelBehavior
.Related Issues
None.
Tests
I added the following tests:
I am not entirely sure what the initiallyFloatingLabel does but I noticed that there is a dy difference when it is set to
true
vsfalse
. I am checking that the correct value is now set whenFloatingLabelBehavior
is set tonever
.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.