Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gen_l10n] Optionally generate list of inputs/outputs #56490

Merged
merged 14 commits into from May 7, 2020
Merged

[gen_l10n] Optionally generate list of inputs/outputs #56490

merged 14 commits into from May 7, 2020

Commits on May 5, 2020

  1. Implement new option for generating json of inputs and outputs w/o fi… 

    …le gen logic
    @shihaohong
    shihaohong committed May 5, 2020
    Configuration menu
    Copy the full SHA
    897b356 View commit details
    Browse the repository at this point in the history

  2. Add json code gen logic

    @shihaohong
    shihaohong committed May 5, 2020
    Configuration menu
    Copy the full SHA
    572b66b View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Fix usage of setOutputFile to be setBaseOutputFile

    @shihaohong
    shihaohong committed May 6, 2020
    Configuration menu
    Copy the full SHA
    84ecd43 View commit details
    Browse the repository at this point in the history

  2. Write new test, improve existings tests

    @shihaohong
    shihaohong committed May 6, 2020
    Configuration menu
    Copy the full SHA
    81d6f8d View commit details
    Browse the repository at this point in the history

  3. Improve code to pass tests

    @shihaohong
    shihaohong committed May 6, 2020
    Configuration menu
    Copy the full SHA
    dd4b989 View commit details
    Browse the repository at this point in the history

  4. Test cleanup

    @shihaohong
    shihaohong committed May 6, 2020
    Configuration menu
    Copy the full SHA
    61be735 View commit details
    Browse the repository at this point in the history

  5. writeOutputFile -> writeOutputFiles in test and implementation

    @shihaohong
    shihaohong committed May 6, 2020
    Configuration menu
    Copy the full SHA
    66f0c98 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Use json.encode instead of a template string replace

    @shihaohong
    shihaohong committed May 7, 2020
    Configuration menu
    Copy the full SHA
    b3762e0 View commit details
    Browse the repository at this point in the history

  2. Gratuitous improvement of test failure message grammar

    @shihaohong
    shihaohong committed May 7, 2020
    Configuration menu
    Copy the full SHA
    42373a5 View commit details
    Browse the repository at this point in the history

  3. Use path.join to make Windows path expects to pass

    @shihaohong
    shihaohong committed May 7, 2020
    Configuration menu
    Copy the full SHA
    147b30a View commit details
    Browse the repository at this point in the history

  4. Remove all "the the"

    @shihaohong
    shihaohong committed May 7, 2020
    Configuration menu
    Copy the full SHA
    49226e2 View commit details
    Browse the repository at this point in the history

  5. Code review feedback on option help text

    @shihaohong
    shihaohong committed May 7, 2020
    Configuration menu
    Copy the full SHA
    552eafb View commit details
    Browse the repository at this point in the history

  6. Use absolute path of MemoryFileSystem in test

    @shihaohong
    shihaohong committed May 7, 2020
    Configuration menu
    Copy the full SHA
    c4588fe View commit details
    Browse the repository at this point in the history

  7. Use fs.path.absolute

    @shihaohong
    shihaohong committed May 7, 2020
    Configuration menu
    Copy the full SHA
    e5ecd5d View commit details
    Browse the repository at this point in the history