Remove direct uses of LocalPlatform #56605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `const LocalPlatform` is used immediately and not passed as a dependency it does not have utility over the static properties from `dart:io`. Remove these uses to reduce the noise around how the instantiable `Platform` class is used.
fluttergithubbot
added
team
tvolkert
approved these changes
May 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
const LocalPlatformis used immediately and not passed as adependency it does not have utility over the static properties from
dart:io. Remove these uses to reduce the noise around how theinstantiable
Platformclass is used.Description
Internal cleanup.
Tests
There are no visible behavior changes, existing tests should pass.