Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message when size has not been set in RenderBox's performLayout should be well versed #58151

Merged
merged 3 commits into from May 28, 2020
Merged

Error message when size has not been set in RenderBox's performLayout should be well versed #58151

merged 3 commits into from May 28, 2020

Conversation

giantsol
Copy link
Contributor

Description

Previously, when RenderBox subclasses didn't set size in performLayout, the error message was'!debugNeedsLayout': is not true., which was not very helpful. That was because of one liner assertion in the middle of debugAssertDoesMeetConstraints(). I think it is now better to remove this because it only prevents us from getting more detailed error message.

Now, we get a message: RenderBox did not set its size during layout.

Related Issues

#40002

Tests

7630f3e

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label May 28, 2020
chunhtai
chunhtai approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor nits

packages/flutter/test/rendering/box_test.dart Outdated

expect(errorDetails, isNotNull);

// Check the ErrorDetails without the stack trace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentence should end with a dot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied!

@fluttergithubbot fluttergithubbot merged commit e853155 into flutter:master May 28, 2020
@giantsol giantsol deleted the performlayout_no_size branch May 28, 2020 22:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@giantsol @chunhtai @googlebot @fluttergithubbot