More useful error messages when you use Stack without a textDirection. #59360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
framework
gspencergoog
approved these changes
Jun 13, 2020
| /// the 'alignment' argument". Should be an adverb phrase describing why. | ||
| /// * hint: explain why this might be happening, for example "The default | ||
| /// value of the 'aligment' argument of the $runtimeType widget is an | ||
| /// AlignmentDirectional value.". Should be a fully punctuated sentence. |
There was a problem hiding this comment.
ultra nit, and only if we're using American punctuation rules (personally, I think it's a dumb rule, but it is what it is):
Suggested change
| /// AlignmentDirectional value.". Should be a fully punctuated sentence. | |
| /// AlignmentDirectional value." Should be a fully punctuated sentence. |
There was a problem hiding this comment.
The string here is a literal, not a quote, so I'm inclined to go with programming punctuation rather than usual prose punctuation.
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
|
Updated as per first suggestion, will land on green. Thanks! |
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.