New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard navigation for the Material Date Picker grid #59586
Keyboard navigation for the Material Date Picker grid #59586
Conversation
packages/flutter/lib/src/material/pickers/calendar_date_picker.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/material/pickers/calendar_date_picker.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/material/pickers/calendar_date_picker.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/material/pickers/calendar_date_picker.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/material/pickers/calendar_date_picker.dart
Outdated
Show resolved
Hide resolved
6bcf2f9
to
055ffbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/flutter/lib/src/material/pickers/calendar_date_picker.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/material/pickers/calendar_date_picker.dart
Outdated
Show resolved
Hide resolved
Moved the day headers into the same grid widget with the rest of the days so they scroll together.
055ffbd
to
c65eb00
Compare
Starting from this commit on master I constantly see the following test failures on my machine. (Perhaps related to my
|
@a14n - Thanks for the report, we'll look into the problem shortly. |
@HansMuller did you manage to work on my problem (or create an issue)? I'm migrating framework to non-nullable and it would be great if I can have clean tests. |
@a14n - sorry about the delay. Unfortunately, @darrenaustin - could you look into this? |
I can reproduce/ignore the issue by using: # no failure
TZ='America/Los_Angeles' flutter test --enable-experiment=non-nullable /home/a14n/flutter/packages/flutter/test/material/date_picker_test.dart
# 3 failures
TZ='Europe/Paris' flutter test --enable-experiment=non-nullable /home/a14n/flutter/packages/flutter/test/material/date_picker_test.dart |
I can reproduce the failure as well:
|
Keyboard navigation for the Material Date Picker grid
Description
Added support for navigating the day grid in the Material Date Picker with just the keyboard. Normal Tab/Shift-Tab navigation can be used to bring focus to the date grid. Once inside the grid, the following keyboard shortcuts are supported:
Focus is only allowed on selectable days, and if the focus moves to a date not in the currently displayed month, the view will be scrolled to show the newly focused day.
Related Issues
#49809
Tests
I added two tests that verify selecting a date with just keyboard actions.
Checklist
///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them?