Reland Characters Usage #59778
Merged
Reland Characters Usage #59778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: material design
This was referenced Jun 18, 2020
Merged
This was referenced Jun 23, 2020
Merged
|
This or #59620 appears to have broken google3 despite my CL to add characters to google3. I must be missing some step. |
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Use Dart's characters package to fix user-facing grapheme cluster bugs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relands #53381, which uses the characters package to fix a bunch of problems with extended grapheme clusters.
The previous PR was reverted because the characters package wasn't available in google3. This is being remedied in a CL that must be merged before this.
Related Issues
Relands #53381
Waiting on a google3 CL to add google3 support for the characters package.Merged.Tests
See #53381
Breaking Change
None, but see #59645 where users reported needing to run
flutter pub getorflutter cleanafter upgrading an older project.