Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter tools] Revert desktop device name changes and print the category instead #60395

Merged
merged 3 commits into from Jun 30, 2020
Merged

[flutter tools] Revert desktop device name changes and print the category instead #60395

merged 3 commits into from Jun 30, 2020

Commits on Jun 26, 2020

  1. [flutter tools] Revert desktop device name changes and print the cate… 

    …gory instead

Revert flutter#58812 and instead make `flutter devices`/`flutter doctor`
print the device category, which is what the IntelliJ IDE plugin
does.  The format will be:

    • deviceName (category) • deviceID • targetPlatformName • osName

This does mean that the device name again will be the same the OS
name for desktop devices.

@devoncarew also suggested suffixing `-device` for the device names.
    @jamesderlin
    jamesderlin committed Jun 26, 2020
    Copy the full SHA
    d8d0916 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Fix tests, revert to the plain device IDs

    @jamesderlin
    jamesderlin committed Jun 30, 2020
    Copy the full SHA
    3a2c448 View commit details
    Browse the repository at this point in the history

  2. Merge commit '59aed97647' into jamesderlin/revert-desktop-device-names

    @jamesderlin
    jamesderlin committed Jun 30, 2020
    Copy the full SHA
    c76a953 View commit details
    Browse the repository at this point in the history