Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Tweaking Material Chip a11y semantics to match buttons (#60141)" #60645

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jun 30, 2020

This reverts commit da489c3.

Description

This was causing golden image tests problems for customer money (9686c887-8d33-4501-8100-083eb72a0297)

Related Issues

#58010

Tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 30, 2020
@gaaclarke gaaclarke requested review from nscobie and renyou June 30, 2020 21:29
@gaaclarke gaaclarke force-pushed the revert-da489c337a654e58b126fa5405a486c56c816383 branch from 69f391e to 227990a Compare June 30, 2020 22:48
@fluttergithubbot fluttergithubbot merged commit e8670de into flutter:master Jul 1, 2020
nscobie added a commit that referenced this pull request Jul 7, 2020
nscobie added a commit that referenced this pull request Jul 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants