Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: TextInputTheme support step 1 of 3. #61008

Closed
wants to merge 1 commit into from

Conversation

darrenaustin
Copy link
Contributor

Description

As part of the larger theme system update, this PR provides a new TextFieldTheme that configures the properties of TextFields. The initial supported properties are the cursorColor and selectionHandleColor, with more to come in future PRs.

As we are updating the default values for each of these properties this will eventually be a breaking change. However, for this first step this is all turned off by default. To turn on the text field theme support you can set the new temporary ThemeData.useTextFieldTheme flag to true.

TBD: description of new defaults and breaking change migration docs

Related Issues

#17635
#56082

Tests

I added tests for the new theme as well as updating the overall ThemeData tests.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them?

This PR specifically won't break any tests, as it is a soft migration. Overall however, after all stages of this are complete it will be a breaking change.

TBD: breaking change docs.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 7, 2020
@darrenaustin darrenaustin marked this pull request as draft July 7, 2020 19:03
@darrenaustin darrenaustin changed the title WIP: TextFieldTheme support step 1. WIP: TextInputTheme support step 1 of 3. Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants